Conversation
Signed-off-by: Polina Sizintseva <polina.sizintseva@flant.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the GitHub Actions workflow to standardize the job output name used for passing the built module image tag to downstream steps/jobs.
Changes:
- Renamed the
build_devjob output key fromMODULES_MODULE_TAGtomodules_module_tag. - Updated downstream references (YAML manifest example and
kubectl patchexample) to use the new output key.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| name: Build and Push images | ||
| outputs: | ||
| MODULES_MODULE_TAG: ${{ steps.modules_module_tag.outputs.MODULES_MODULE_TAG }} | ||
| modules_module_tag: ${{ steps.modules_module_tag.outputs.MODULES_MODULE_TAG }} |
There was a problem hiding this comment.
The job output key was renamed to modules_module_tag, but it still sources a step output named MODULES_MODULE_TAG. Having two different identifiers for the same concept (different casing + duplicated module in the name) is easy to confuse and increases the chance of future misreferences. Consider aligning the step output name and the job output key to the same identifier (e.g., both modules_module_tag or a clearer singular like module_tag) so producers/consumers match consistently.
No description provided.