Merged
Conversation
Collaborator
gshigin
commented
Mar 26, 2025
gshigin
commented
- Removed clock dependency from OutdatedSampleEncoder, delegating merge logic to the caller.
- Updated tests to reflect the new behavior.
gshigin
changed the title
cherep58
reviewed
Mar 26, 2025
cherep58
reviewed
Mar 26, 2025
added 2 commits
March 26, 2025 18:55
gshigin
force-pushed
the
encoder-remove-clock
branch
from
7fb859d to
31ca4f7
Compare
cherep58
approved these changes
Mar 27, 2025
Collaborator
Author
|
This pull request requires changes on the Go side to trigger chunk merge by a timer. |
vporoshok
approved these changes
Apr 10, 2025
Signed-off-by: Bastrykov Evgeniy <vporoshok@gmail.com>
vporoshok
approved these changes
Apr 10, 2025
vporoshok
approved these changes
Apr 10, 2025
vporoshok
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.