Skip to content

feat(vd): remove finalizer from unmounted vd#1014

Merged
hardcoretime merged 1 commit into
mainfrom
feat/vd/remove-finalizer-from-unmounted-vd
May 12, 2025
Merged

feat(vd): remove finalizer from unmounted vd#1014
hardcoretime merged 1 commit into
mainfrom
feat/vd/remove-finalizer-from-unmounted-vd

Conversation

@hardcoretime
Copy link
Copy Markdown
Contributor

@hardcoretime hardcoretime commented May 6, 2025

Description

vd-protection will be removed from the virtual disk if the virtual machine is stopped.

Why do we need it, and what problem does it solve?

This is necessary for the new feature, 'Restore Virtual Machine with Force Option.' Before restoring the virtual machine, it should be stopped to restore the virtual disk.

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vd
type: feature
summary: "Now the stopped virtual machine does not protect the virtual disk, and the virtual disk becomes available for deletion"
impact_level: low

@hardcoretime hardcoretime added this to the v0.18.0 milestone May 6, 2025
@hardcoretime hardcoretime added the e2e/run Run e2e test on cluster of PR author label May 6, 2025
@deckhouse-BOaTswain
Copy link
Copy Markdown
Contributor

deckhouse-BOaTswain commented May 6, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label May 6, 2025
@hardcoretime hardcoretime force-pushed the feat/vd/remove-finalizer-from-unmounted-vd branch from fc56eaf to fecc90c Compare May 7, 2025 07:39
@hardcoretime hardcoretime requested a review from LopatinDmitr May 7, 2025 07:46
Comment thread images/virtualization-artifact/pkg/controller/vd/internal/protection.go Outdated
@hardcoretime hardcoretime added the e2e/run Run e2e test on cluster of PR author label May 7, 2025
@deckhouse-BOaTswain
Copy link
Copy Markdown
Contributor

deckhouse-BOaTswain commented May 7, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: cancelled.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label May 7, 2025
@hardcoretime hardcoretime force-pushed the feat/vd/remove-finalizer-from-unmounted-vd branch from fecc90c to 8161ffb Compare May 7, 2025 11:09
LopatinDmitr
LopatinDmitr previously approved these changes May 7, 2025
@hardcoretime hardcoretime added the e2e/run Run e2e test on cluster of PR author label May 12, 2025
@deckhouse-BOaTswain
Copy link
Copy Markdown
Contributor

deckhouse-BOaTswain commented May 12, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label May 12, 2025
`vd-protection` will be removed from the virtual disk if the virtual machine is stopped.

Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
@hardcoretime hardcoretime force-pushed the feat/vd/remove-finalizer-from-unmounted-vd branch from 8161ffb to 310da17 Compare May 12, 2025 08:37
@hardcoretime hardcoretime added the e2e/run Run e2e test on cluster of PR author label May 12, 2025
@deckhouse-BOaTswain
Copy link
Copy Markdown
Contributor

deckhouse-BOaTswain commented May 12, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label May 12, 2025
@universal-itengineer universal-itengineer modified the milestones: v0.18.0, v0.19.0 May 12, 2025
@LopatinDmitr LopatinDmitr self-requested a review May 12, 2025 11:19
@hardcoretime hardcoretime merged commit 1afb2c5 into main May 12, 2025
64 of 68 checks passed
@hardcoretime hardcoretime deleted the feat/vd/remove-finalizer-from-unmounted-vd branch May 12, 2025 11:56
yachmenevas pushed a commit that referenced this pull request Oct 15, 2025
`vd-protection` will be removed from the virtual disk if the virtual machine is stopped.

Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants