Skip to content

fix(images): disable false positive error logs about not ready datasource#1050

Merged
eofff merged 4 commits into
mainfrom
fix/api/do-not-display-error-when-datasource-is-nil
May 23, 2025
Merged

fix(images): disable false positive error logs about not ready datasource#1050
eofff merged 4 commits into
mainfrom
fix/api/do-not-display-error-when-datasource-is-nil

Conversation

@eofff
Copy link
Copy Markdown
Contributor

@eofff eofff commented May 15, 2025 •
edited
Loading

Description

Disable false positive error logs about not ready datasource.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: images 
type: fix
summary: Disable false positive error logs about not ready datasource.
impact_level: low

@eofff eofff force-pushed the fix/api/do-not-display-error-when-datasource-is-nil branch from f4f60b2 to d00f154 Compare May 15, 2025 08:44
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label May 15, 2025
@deckhouse-BOaTswain
Copy link
Copy Markdown
Contributor

deckhouse-BOaTswain commented May 15, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: success.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label May 15, 2025
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label May 15, 2025
@deckhouse-BOaTswain
Copy link
Copy Markdown
Contributor

deckhouse-BOaTswain commented May 15, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: cancelled.

@eofff eofff force-pushed the fix/api/do-not-display-error-when-datasource-is-nil branch from 10d9121 to 054bfd9 Compare May 15, 2025 13:14
@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label May 15, 2025
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label May 15, 2025
@deckhouse-BOaTswain
Copy link
Copy Markdown
Contributor

deckhouse-BOaTswain commented May 15, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: success.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label May 15, 2025
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label May 15, 2025
@deckhouse-BOaTswain
Copy link
Copy Markdown
Contributor

deckhouse-BOaTswain commented May 15, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label May 15, 2025
@deckhouse-BOaTswain
Copy link
Copy Markdown
Contributor

deckhouse-BOaTswain commented May 15, 2025

Workflow has started.
Follow the progress here: Workflow Run

@eofff eofff changed the title test fix(images): disable false positive error logs about not ready datasource May 16, 2025
@eofff eofff added this to the v0.19.0 milestone May 16, 2025
@eofff eofff marked this pull request as ready for review May 16, 2025 01:58
Isteb4k
Isteb4k requested changes May 20, 2025
View reviewed changes
Comment thread images/virtualization-artifact/pkg/controller/cvi/internal/source/object_ref.go Outdated
@eofff eofff force-pushed the fix/api/do-not-display-error-when-datasource-is-nil branch from 054bfd9 to bd8b659 Compare May 21, 2025 12:03
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label May 21, 2025
@deckhouse-BOaTswain
Copy link
Copy Markdown
Contributor

deckhouse-BOaTswain commented May 21, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: cancelled.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label May 21, 2025
@eofff eofff requested a review from Isteb4k May 22, 2025 07:17
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label May 22, 2025
@deckhouse-BOaTswain
Copy link
Copy Markdown
Contributor

deckhouse-BOaTswain commented May 22, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: cancelled.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label May 22, 2025
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label May 23, 2025
@deckhouse-BOaTswain
Copy link
Copy Markdown
Contributor

deckhouse-BOaTswain commented May 23, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: success.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label May 23, 2025
Isteb4k
Isteb4k previously approved these changes May 23, 2025
View reviewed changes
Valeriy Khorunzhin added 3 commits May 23, 2025 17:47
test
7bb9157 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
revert one line
2241646 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
fix
2e74db9 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
@eofff eofff force-pushed the fix/api/do-not-display-error-when-datasource-is-nil branch from 259f969 to 2e74db9 Compare May 23, 2025 14:47
fix rebase
9f6e8bd 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
@eofff eofff merged commit d676433 into main May 23, 2025
17 of 18 checks passed
@eofff eofff deleted the fix/api/do-not-display-error-when-datasource-is-nil branch May 23, 2025 14:51
yachmenevas pushed a commit that referenced this pull request Oct 15, 2025
@eofff
fix(images): disable false positive error logs about not ready dataso…
f2f4208 
…urce (#1050)

Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Isteb4k Isteb4k Isteb4k approved these changes

@yaroslavborbat yaroslavborbat Awaiting requested review from yaroslavborbat yaroslavborbat is a code owner

@hardcoretime hardcoretime Awaiting requested review from hardcoretime hardcoretime is a code owner

@danilrwx danilrwx Awaiting requested review from danilrwx danilrwx is a code owner

Assignees

@eofff eofff

Labels

None yet

Projects

None yet

Milestone

v0.19.0

Development

Successfully merging this pull request may close these issues.

3 participants

@eofff @deckhouse-BOaTswain @Isteb4k