fix(core): fix setting LastTransitionTime in condition if reason changed

[eofff]

Description

Fix setting LastTransitionTime in condition if reason changed.

Checklist

• The code is covered by unit tests.
• e2e tests passed.
• Documentation updated according to the changes.
• Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: core
type: fix
summary: Fix setting LastTransitionTime in condition if reason changed.
impact_level: low

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Condition builder now resets LastTransitionTime to the current time when a new timestamp isn’t provided or older, ensuring transitions are tracked correctly; the e2e test config’s obsolete log filter entry was also removed.

Class diagram for updated Condition handling in SetCondition

classDiagram
    class Conder
    class "metav1.Condition" {
        Time LastTransitionTime
        string Reason
    }
    class "SetCondition()" {
    }
    Conder <|-- "SetCondition()"
    "SetCondition()" --> "metav1.Condition" : updates
    "metav1.Condition" : LastTransitionTime
    "metav1.Condition" : Reason
    "SetCondition()" : if newCondition.LastTransitionTime > existingCondition.LastTransitionTime
    "SetCondition()" : else set LastTransitionTime to now

Loading

Flow diagram for LastTransitionTime update logic in SetCondition

flowchart TD
    A["Check if newCondition.LastTransitionTime is set and newer"] -->|Yes| B["Set existingCondition.LastTransitionTime = newCondition.LastTransitionTime"]
    A -->|No| C["Set existingCondition.LastTransitionTime = now"]

Loading

File-Level Changes

Change	Details	Files
Condition LastTransitionTime fallback logic added	Added else branch to assign current time when new timestamp is not newer	images/virtualization-artifact/pkg/controller/conditions/builder.go
Outdated log filter removed in e2e configuration	Removed the 'lastTransitionTime: Required value' entry from logFilter	tests/e2e/default_config.yaml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deckhouse-BOaTswain]

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

[deckhouse-BOaTswain]

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}