Skip to content

fix(core): fix setting LastTransitionTime in condition if reason changed #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 8, 2025
Merged

fix(core): fix setting LastTransitionTime in condition if reason changed #1543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
efef182
fix
Oct 7, 2025
871ce7f
remove errored
Oct 8, 2025
04b5c7f
do not touch magic)
Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions images/virtualization-artifact/pkg/controller/conditions/builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ func SetCondition(c Conder, conditions *[]metav1.Condition) {
if !newCondition.LastTransitionTime.IsZero() &&
newCondition.LastTransitionTime.After(existingCondition.LastTransitionTime.Time) {
existingCondition.LastTransitionTime = newCondition.LastTransitionTime
} else {
existingCondition.LastTransitionTime = metav1.NewTime(time.Now())
}
}

Expand Down
1 change: 0 additions & 1 deletion tests/e2e/default_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ logFilter:
- "the server rejected our request due to an error in our request" # Err.
- "failed to sync powerstate" # Msg.
- "does not have a pvc reference" # "err": "kvvm head-345e7b6a-testcases-image-hotplug/head-345e7b6a-vm-image-hotplug spec volume vi-head-345e7b6a-vi-alpine-http does not have a pvc reference"
- "lastTransitionTime: Required value" # Err.
- "virtualmachineipaddressleases.virtualization.deckhouse.io "
- "Forbidden: no new finalizers can be added if the object is being deleted, found new finalizers"
- "Failed to watch" # error if virtualization-controller restarts during tests. "msg": "Failed to watch", "err": "Get \"http://127.0.0.1:23915/apis/virtualization.deckhouse.io/v1alpha2/virtualmachinerestores?allowWatchBookmarks=true\u0026resourceVersion=709816257\u0026timeoutSeconds=310\u0026watch=true\": context canceled"
Expand Down
Loading