chore(module): prevent error patching empty annotations #1723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diafour
requested review from
nevermarine and
universal-itengineer
as code owners
- Do not add keep resource annotation if there are no helm annotations on vmclass/generic. Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
diafour
force-pushed
the
chore/module/prevent-patch-error-for-instal-vmclass-generic-hook
branch
from
ce1ea7b to
ae2d8a1
Compare
Isteb4k
approved these changes
Nov 20, 2025
diafour
deleted the
chore/module/prevent-patch-error-for-instal-vmclass-generic-hook
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why do we need it, and what problem does it solve?
Fix for rare situation when module installation is failed after successful execution of hooks. The problem is that hook will block the main queue in this situation.
What is the expected result?
No queue blocking by the 'install-vmclass-generic' hook.
Checklist