Skip to content

fix(module): remove validationadmissionpolicy module hooks #1771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 2, 2025
Merged

fix(module): remove validationadmissionpolicy module hooks #1771

merged 3 commits into from
Dec 2, 2025

Conversation

@nevermarine
Copy link
Collaborator

@nevermarine nevermarine commented Nov 28, 2025 •
edited by Isteb4k
Loading

Description

Remove outdated hook for migrating ValidationAdmissionPolicy, as it is conflicts with Kubernetes version >=1.34.

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: module
type: fix
summary: "The deprecated part of the configuration has been removed, which could have prevented the virtualization module from upgrading in clusters running Kubernetes version 1.34 and above."

@nevermarine nevermarine added this to the v1.3.0 milestone Nov 28, 2025
@nevermarine
fix(module): update apiversion for validationadmissionpolicy
132d9a8 
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
@nevermarine
remove hook
ab87d22 
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
@nevermarine nevermarine force-pushed the fix/core/update-apiversion-for-validationadmissionpolicy branch from 6fd8dcb to ab87d22 Compare December 2, 2025 10:01
@nevermarine nevermarine changed the title fix(module): update apiversion for validationadmissionpolicy chore(module): remove validationadmissionpolicy module hooks Dec 2, 2025
@nevermarine nevermarine modified the milestones: v1.3.0, v1.2.1 Dec 2, 2025
@nevermarine
remove from register
ea37fd0 
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
@nevermarine nevermarine marked this pull request as ready for review December 2, 2025 10:11
@nevermarine nevermarine changed the title chore(module): remove validationadmissionpolicy module hooks fix(module): remove validationadmissionpolicy module hooks Dec 2, 2025
@nevermarine nevermarine merged commit 161b4c2 into main Dec 2, 2025
29 of 30 checks passed
@nevermarine nevermarine deleted the fix/core/update-apiversion-for-validationadmissionpolicy branch December 2, 2025 10:53
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Dec 2, 2025
Merged
@nevermarine
Copy link
Collaborator Author

nevermarine commented Dec 3, 2025

/backport v1.2

github-actions bot pushed a commit that referenced this pull request Dec 3, 2025
@nevermarine
fix(module): remove validationadmissionpolicy module hooks (#1771)
9a35478 
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
deckhouse-BOaTswain added a commit that referenced this pull request Dec 3, 2025
@deckhouse-BOaTswain @nevermarine
Backport: fix(module): remove validationadmissionpolicy module hooks (#…
913f88c 
…1786)

fix(module): remove validationadmissionpolicy module hooks (#1771)

Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
Co-authored-by: Maksim Fedotov <maksim.fedotov@flant.com>
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Dec 3, 2025

Cherry pick PR 1786 to the branch release-1.2 successful!

@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Dec 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Isteb4k Isteb4k Isteb4k approved these changes

@universal-itengineer universal-itengineer Awaiting requested review from universal-itengineer universal-itengineer is a code owner

Assignees

@nevermarine nevermarine

Labels

status/backport/success

Projects

None yet

Milestone

v1.2.1

Development

Successfully merging this pull request may close these issues.

4 participants

@nevermarine @deckhouse-BOaTswain @Isteb4k