feat(vm): add target migration #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

hardcoretime merged 31 commits into main from feat/vm/add-target-migration

Feb 5, 2026

+678 −76

Contributor

hardcoretime commented Jan 14, 2026 •

edited by Isteb4k

Loading

Description

A virtual machine can now be migrated to a particular node using the NodeSelector option in the virtual machine operation.

Why do we need it, and what problem does it solve?

This is required to enhance the user experience with virtual machine migration.

What is the expected result?

A virtual machine can be migrated to a particular node using defined labels.

Checklist

The code is covered by unit tests.
e2e tests passed.
Documentation updated according to the changes.
Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vm
type: feature
summary: Added support for targeted migration of virtual machines. To do this, create a [VirtualMachineOperation](/modules/virtualization/cr.html#virtualmachineoperation) resource with the `Migrate` type and specify `.spec.migrate.nodeSelector` to migrate the virtual machine to the corresponding node.

hardcoretime added this to the v1.5.0 milestone

github-actions bot assigned hardcoretime

hardcoretime force-pushed the feat/vm/add-target-migration branch 6 times, most recently from 065512f to cca7297 Compare

January 19, 2026 16:42

hardcoretime marked this pull request as ready for review

January 19, 2026 16:58

hardcoretime requested review from Isteb4k, fl64, goganat, yaroslavborbat and z9r5 as code owners

January 19, 2026 16:58

z9r5 previously approved these changes

View reviewed changes

yaroslavborbat requested changes

View reviewed changes

api/core/v1alpha2/virtual_machine_operation.go Show resolved Hide resolved

images/virtualization-artifact/pkg/controller/vmop/migration/internal/service/migration.go Show resolved Hide resolved

src/cli/internal/cmd/lifecycle/vmop/vmop.go Outdated Show resolved Hide resolved

src/cli/internal/cmd/lifecycle/lifecycle.go Outdated Show resolved Hide resolved

test/e2e/vm/target_migration.go Outdated Show resolved Hide resolved

test/e2e/vm/target_migration.go Outdated Show resolved Hide resolved

test/e2e/vm/target_migration.go Outdated Show resolved Hide resolved

yaroslavborbat requested changes

View reviewed changes

images/virtualization-artifact/pkg/controller/vmop/vmop_webhook.go Show resolved Hide resolved

hardcoretime dismissed z9r5’s stale review via

d804996

January 21, 2026 00:21

hardcoretime force-pushed the feat/vm/add-target-migration branch from cca7297 to d804996 Compare

January 21, 2026 00:21

hardcoretime requested a review from yaroslavborbat

January 21, 2026 00:30

yaroslavborbat requested changes

View reviewed changes

test/e2e/vm/target_migration.go Outdated Show resolved Hide resolved

test/e2e/vm/target_migration.go Outdated Show resolved Hide resolved

images/virtualization-artifact/pkg/controller/vmop/migration/internal/service/migration.go Outdated Show resolved Hide resolved

hardcoretime requested a review from yaroslavborbat

January 21, 2026 08:48

yaroslavborbat previously approved these changes

View reviewed changes

hardcoretime dismissed yaroslavborbat’s stale review via

1ddba69

January 21, 2026 13:26

hardcoretime requested review from yaroslavborbat and z9r5

January 21, 2026 13:32

hardcoretime force-pushed the feat/vm/add-target-migration branch 4 times, most recently from 6fe45ee to 1f02fd0 Compare

January 21, 2026 23:16

Roman Sysoev and others added 20 commits

February 5, 2026 13:57


          year's fix

f1cddb0

Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>


          improve e2e context

795e8cb

Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>


          feat(vm): resolve review comments

fb2d35e

Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>


          feat(vm): add force opt to target migration

3ad76e1

Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>


          feat(vm): resolve review comments

bc6d689

- add default Alpine-BIOS virtual disk
- set the value to '20%' as the default in NewMinimalVM

Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>


          doc(vm): add target migration

650f91f

Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>


          feat(vm): add new field migrate.nodeName

a1d08db

Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>


          feat(vm): change target migration feature

e3665ff

- replace nodeSelector with targetNodeName in d8 v migrate
- target migration is EE feature

Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>


          docs: merge suggestion

9f13eb4

Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>


          feat(vm): change docs and split unit tests by edition

5d842a4

Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>


          doc(vm): improve target migration section

997103b

Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>


          feat(vmop): optimize vmop builder option

a4909d6

Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>


          Apply suggestions from code review

2a41ce4

Co-authored-by: Denis Rebenok <60424108+denmaloyreb@users.noreply.github.com>
Signed-off-by: Artem Kladov <6360800+z9r5@users.noreply.github.com>


          docs(vm): resolve linter warnings and regenerate CRD

85e35ff

Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>


          test: add NewUnlocked feature gate func

fda27c1

This is required in testing scenarios with EE version.

Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>


          fix(vmop): fail vmop if target migration in not available

e41bf4c

Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>


          fix(vmop): fail fast if target migration is not available

78651a1

Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>


          feat(vmop): resolve review comments

Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>


          fix(vmop): do not validate --target-node-name default value

62d7c59

Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>


          feat(vmop): resolve review comments

d08548b

Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>

hardcoretime force-pushed the feat/vm/add-target-migration branch from 62aa333 to d08548b Compare

February 5, 2026 10:58


          feat(vmop): refactor node name validation

ce77795

Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>

hardcoretime requested a review from Isteb4k

February 5, 2026 11:30

Roman Sysoev added 2 commits

February 5, 2026 14:37


          test: resolve linter error

903db8b

Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>


          feat(vmop): refactor target node name validation

a0d1b26

Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>

Isteb4k approved these changes

View reviewed changes

hardcoretime merged commit cd5e02a into main

25 of 28 checks passed

hardcoretime deleted the feat/vm/add-target-migration branch

February 5, 2026 15:56

This was referenced Feb 5, 2026

Changelog v1.5.0 #1860

Merged

Backport: Changelog v1.5.0 #1972

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Isteb4k Isteb4k approved these changes

z9r5 z9r5 left review comments

denmaloyreb denmaloyreb left review comments

yaroslavborbat yaroslavborbat left review comments

prismagod prismagod left review comments

fl64 Awaiting requested review from fl64 fl64 is a code owner

goganat Awaiting requested review from goganat goganat is a code owner

Labels

None yet