fix(vmrestore): drop usb devices in best effort clone#2076
Merged
Conversation
8ba7803 to
0d1ce92
Compare
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
0d1ce92 to
7e7bb96
Compare
Isteb4k
approved these changes
Mar 10, 2026
Isteb4k
pushed a commit
that referenced
this pull request
Mar 10, 2026
Description Fix VM clone behavior in BestEffort mode when source VM has attached USB devices. The restore handler now filters out spec.usbDevices during clone validation for SnapshotOperationModeBestEffort, so clone creation is not blocked by USB dependencies. Also extended unit tests in vm_restorer_test.go to verify: USB devices are removed in BestEffort mode USB devices are preserved in Strict mode --------- Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com> (cherry picked from commit 8931e9c)
This was referenced Mar 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix VM clone behavior in
BestEffortmode when source VM has attached USB devices.The restore handler now filters out
spec.usbDevicesduring clone validation forSnapshotOperationModeBestEffort, so clone creation is not blocked by USB dependencies.Also extended unit tests in
vm_restorer_test.goto verify:Why do we need it, and what problem does it solve?
In BestEffort clone mode, we should tolerate dependencies that cannot be reproduced in the clone target.
USB devices may be busy or attached to another VM, and carrying them over to a cloned VM can cause clone failures or invalid restore behavior. This change makes BestEffort clone semantics consistent by dropping USB attachments from the cloned VM spec.
What is the expected result?
spec.usbDevices.BestEffortmode.spec.usbDevices.Strictmode.spec.usbDevicesare kept in the cloned VM.Checklist
Changelog entries