fix(vd): allow only rollback storage class during active migration#2116
Merged
LopatinDmitr merged 1 commit intomainfrom Mar 24, 2026
Merged
Conversation
LopatinDmitr
force-pushed
the
fix/vd/validate-storage-class-with-volume-migration
branch
2 times, most recently
from
6b62b30 to
f6dc043
Compare
eofff
previously approved these changes
Mar 24, 2026
Prevent changing VirtualDisk storage class to an arbitrary value while migration is in progress by allowing only rollback to the source PVC storage class. Add validator tests for forbidden A->B->C changes and allowed rollback to A. Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
LopatinDmitr
force-pushed
the
fix/vd/validate-storage-class-with-volume-migration
branch
from
f6dc043 to
84c2a56
Compare
eofff
approved these changes
Mar 24, 2026
LopatinDmitr
deleted the
fix/vd/validate-storage-class-with-volume-migration
branch
Isteb4k
pushed a commit
that referenced
this pull request
Mar 25, 2026
…2116) - Prevent changing VirtualDisk storage class to an arbitrary value while migration is in progress by allowing only rollback to the source PVC storage class. Add validator tests for forbidden A->B->C changes and allowed rollback to A. Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com> (cherry picked from commit 7c2dca1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent changing VirtualDisk storage class to an arbitrary value while migration is in progress by allowing only rollback to the source PVC storage class. Added validator tests for forbidden
A->B->Cchanges and allowed rollback to A.Why do we need it, and what problem does it solve?
When a migration is active, changing the storage class may cause the rare error `VolumesUpdateError'.
What is the expected result?
Attempt to change the storage class during active migration should fail except when reverting to the original storage class.
Checklist
Changelog entries