feat(vd): add quota override label for PVC migration#2148
Merged
Conversation
- Add resource-quota-overrides.deckhouse.io/ignore label to target PVC when it is created during migration (handleMigratePrepareTarget) - Remove the label from target PVC before deleting source PVC (handleComplete) to avoid x0 quota scenario During migration, the quota will be x2 for a short time, but that's expected. The main goal is to avoid x0 quota. Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
danilrwx
force-pushed
the
fix/vd/quota-exclude-for-vd-migration
branch
from
d56ecd1 to
4599790
Compare
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
danilrwx
force-pushed
the
fix/vd/quota-exclude-for-vd-migration
branch
from
4f9662f to
73ee537
Compare
Move quota override label from target PVC to source PVC during migration: - Add label to source PVC after target PVC is successfully created (prevents x0 quota) - Remove label from source PVC if migration fails (handleRevert, handleComplete) - Source PVC is excluded from quota while migration is in progress - If migration fails, quota starts counting source PVC again This prevents double counting of storage resources during PVC migration when both source and target PVCs exist simultaneously. Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
danilrwx
force-pushed
the
fix/vd/quota-exclude-for-vd-migration
branch
from
73ee537 to
481dee0
Compare
…tion" This reverts commit 481dee0. Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
danilrwx
force-pushed
the
fix/vd/quota-exclude-for-vd-migration
branch
2 times, most recently
from
2164883 to
d261e75
Compare
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
danilrwx
force-pushed
the
fix/vd/quota-exclude-for-vd-migration
branch
from
d261e75 to
38dbb63
Compare
Isteb4k
approved these changes
Mar 25, 2026
danilrwx
added a commit
that referenced
this pull request
Mar 25, 2026
* feat(vd): add quota override label for PVC migration Add resource-quota-overrides.deckhouse.io/ignore label to target PVC during migration to prevent double counting. --------- Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
Isteb4k
pushed a commit
that referenced
this pull request
Mar 25, 2026
* feat(vd): add quota override label for PVC migration Add resource-quota-overrides.deckhouse.io/ignore label to target PVC during migration to prevent double counting. --------- Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com> (cherry picked from commit 4acea76)
danilrwx
added a commit
that referenced
this pull request
Mar 25, 2026
* feat(vd): add quota override label for PVC migration Add resource-quota-overrides.deckhouse.io/ignore label to target PVC during migration to prevent double counting. --------- Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
Isteb4k
pushed a commit
that referenced
this pull request
Mar 25, 2026
* feat(vd): add quota override label for PVC migration Add resource-quota-overrides.deckhouse.io/ignore label to target PVC during migration to prevent double counting. --------- Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com> (cherry picked from commit 4acea76)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
resource-quota-overrides.deckhouse.io/ignorelabel to target PVC during migration to prevent double counting.Why do we need it, and what problem does it solve?
When migrating PVCs (e.g., local disk to storageClass change), both source and target PVCs exist temporarily. Without the label, quota counts both PVCs (x2), potentially exceeding limits.
Migration State Table
What is the expected result?
resource-quota-overrides.deckhouse.io/ignorelabelChecklist
Changelog entries