fix(cli): force handling for VM lifecycle operations initiated via CLI/VMOP#2168
Merged
fix(cli): force handling for VM lifecycle operations initiated via CLI/VMOP#2168
Conversation
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
yaroslavborbat
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix force handling for VM lifecycle operations initiated via CLI/VMOP:
stopnow correctly propagates--forcetoVirtualMachineOperation.spec.force.restartnow honorsspec.forcein the powerstate controller and performs force restart path when requested.Previously:
d8 v stop --forcehad no effect because CLI hardcodedforce=falsefor Stop VMOP.VirtualMachineOperationwithtype=Restartandspec.force=truewas processed via graceful restart annotation path, effectively ignoring force behavior.Why do we need it, and what problem does it solve?
Users expect force lifecycle actions to be applied consistently:
stop --forceshould trigger force stop semantics.restart --forceshould trigger immediate restart semantics (force path), not graceful shutdown waiting behavior.These fixes align implementation with API contract and documented
spec.forcesemantics.What is the expected result?
d8 v stop <vm> --force.VirtualMachineOperationhasspec.force=trueand force-stop behavior is applied.VirtualMachineOperationwithtype=Restartandspec.force=true.powerstate.RestartVM(..., true)) instead of annotation-only graceful path.Checklist
Changelog entries