Skip to content

test: fix e2e VirtualMachineMigration#2208

Merged
universal-itengineer merged 9 commits into
mainfrom
fix/test/e2e-virtualmachinemigration
Apr 13, 2026
Merged

test: fix e2e VirtualMachineMigration#2208
universal-itengineer merged 9 commits into
mainfrom
fix/test/e2e-virtualmachinemigration

Conversation

@universal-itengineer
Copy link
Copy Markdown
Member

@universal-itengineer universal-itengineer commented Apr 13, 2026

Description

Fixes and improvements to VirtualMachineMigration e2e tests.

Changes:

  • Removed commented-out disk verification code
  • Refactored By blocks for better readability
  • Added informative checks with VM name display
  • Moved disk verification after migration into a separate loop with SSH accessibility check
  • Fix vm CVI for vmBIOS to alpine

Why do we need it, and what problem does it solve?

Migration tests contained commented-out code and lacked clear verification structure. After migration completes, VMs must remain accessible via SSH and retain their original disk count.

What is the expected result?

After VirtualMachine migration:

  1. VM is accessible via SSH
  2. Disk count matches the original value

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
@universal-itengineer universal-itengineer added this to the v1.8.0 milestone Apr 13, 2026
@universal-itengineer universal-itengineer marked this pull request as ready for review April 13, 2026 12:39
Comment thread test/e2e/vm/migration.go Outdated
Comment thread test/e2e/vm/migration.go Outdated
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
@universal-itengineer universal-itengineer force-pushed the fix/test/e2e-virtualmachinemigration branch from c8c78f2 to faf4281 Compare April 13, 2026 13:39
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
@universal-itengineer universal-itengineer force-pushed the fix/test/e2e-virtualmachinemigration branch from 3b97879 to 10faf1f Compare April 13, 2026 14:48
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
@universal-itengineer universal-itengineer force-pushed the fix/test/e2e-virtualmachinemigration branch from ce7d0d5 to 54547ed Compare April 13, 2026 15:21
Comment thread test/e2e/vm/migration.go Outdated
hardcoretime
hardcoretime previously approved these changes Apr 13, 2026
@universal-itengineer universal-itengineer force-pushed the fix/test/e2e-virtualmachinemigration branch from dfe6911 to 2fc4c9c Compare April 13, 2026 16:30
@universal-itengineer universal-itengineer force-pushed the fix/test/e2e-virtualmachinemigration branch 2 times, most recently from 20a408a to cf1eb28 Compare April 13, 2026 17:20
Co-authored-by: Roman Sysoev <36233932+hardcoretime@users.noreply.github.com>
Signed-off-by: Nikita Korolev <141920865+universal-itengineer@users.noreply.github.com>
@universal-itengineer universal-itengineer force-pushed the fix/test/e2e-virtualmachinemigration branch from cf1eb28 to 21e8c9a Compare April 13, 2026 19:04
@universal-itengineer universal-itengineer merged commit 0198448 into main Apr 13, 2026
29 of 30 checks passed
@universal-itengineer universal-itengineer deleted the fix/test/e2e-virtualmachinemigration branch April 13, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants