fix(vmop): restore requested virtual disk size from snapshot metadata#2278
Merged
Conversation
2c500cd to
75627bf
Compare
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
75627bf to
52020de
Compare
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
diafour
reviewed
Apr 28, 2026
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
diafour
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restore the original requested VirtualDisk PVC size when restoring VM disks from snapshots.
The change stores
vd-original-sizein the VolumeSnapshot annotations during VirtualDiskSnapshot creation and uses this annotation when VMOP restores VirtualDisks from snapshot resources. If the annotation is absent, the restore flow keeps the previous behavior.Why do we need it, and what problem does it solve?
A restored VirtualDisk could be created without the original requested PVC size and rely on the snapshot restore defaults. This could make the restored disk size differ from the size requested by the source VirtualDisk.
Persisting and reading the original size from snapshot metadata makes VMOP restore recreate VirtualDisks with the same requested PVC size as the original disk.
What is the expected result?
spec.persistentVolumeClaim.sizeequal to the original requested size.virtualization.deckhouse.io/vd-original-sizeannotation.Checklist
Changelog entries