Skip to content

test(vm): filter only virt-launcher pods in volume migration test#2421

Merged
yaroslavborbat merged 1 commit into
mainfrom
test/fix-test-migrate-to-not-matched-node
Jun 1, 2026
Merged

test(vm): filter only virt-launcher pods in volume migration test#2421
yaroslavborbat merged 1 commit into
mainfrom
test/fix-test-migrate-to-not-matched-node

Conversation

@yaroslavborbat
Copy link
Copy Markdown
Member

@yaroslavborbat yaroslavborbat commented Jun 1, 2026

Description

Add label selector to filter only virt-launcher pods when checking pod count during VM volume migration test.
Previously, all pods in the namespace were listed, including hotplug volume (hp) pods, which caused incorrect count assertions.

Why do we need it, and what problem does it solve?

During the volume migration e2e test, the code checks that exactly 2 pods exist (source and target virt-launcher).
Without filtering, hotplug volume pods are also counted, leading to flaky test failures when the actual virt-launcher pod count is correct but total pod count differs.

What is the expected result?

  1. Trigger VM volume migration
  2. Verify that only virt-launcher pods are counted during migration
  3. Test passes consistently without flakiness caused by hotplug pods

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: test
type: chore
summary: Filter only virt-launcher pods in volume migration e2e test to avoid flakiness caused by hotplug volume pods.
impact_level: low

Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>
@yaroslavborbat yaroslavborbat requested a review from Isteb4k as a code owner June 1, 2026 09:36
@yaroslavborbat yaroslavborbat added this to the v1.9.0 milestone Jun 1, 2026
@yaroslavborbat yaroslavborbat merged commit ddd7cda into main Jun 1, 2026
31 of 34 checks passed
@yaroslavborbat yaroslavborbat deleted the test/fix-test-migrate-to-not-matched-node branch June 1, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants