Skip to content

fix: resolve xml dir for non root setup#2434

Merged
yaroslavborbat merged 3 commits into
mainfrom
fix/vlctl-domain
Jun 3, 2026
Merged

fix: resolve xml dir for non root setup#2434
yaroslavborbat merged 3 commits into
mainfrom
fix/vlctl-domain

Conversation

@yaroslavborbat

@yaroslavborbat yaroslavborbat commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

resolve xml dir for non root setup

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vm
type: fix 
summary: resolve xml dir for non root setup
impact_level: low

@yaroslavborbat
fix: resolve xml dir for non root setup
cdde2bc 
Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>
@yaroslavborbat yaroslavborbat added this to the v1.8.3 milestone Jun 2, 2026
diafour
diafour reviewed Jun 2, 2026
View reviewed changes
Comment thread images/virt-launcher/vlctl/cmd/vlctl/app/domain.go Outdated
@yaroslavborbat @diafour
Update images/virt-launcher/vlctl/cmd/vlctl/app/domain.go
09a7ede 
Co-authored-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Signed-off-by: Yaroslav Borbat <86148689+yaroslavborbat@users.noreply.github.com>
diafour
diafour reviewed Jun 2, 2026
View reviewed changes
Comment thread images/virt-launcher/vlctl/cmd/vlctl/app/domain.go Outdated
@yaroslavborbat @diafour
Apply suggestion from @diafour
b41c9da 
Co-authored-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Signed-off-by: Yaroslav Borbat <86148689+yaroslavborbat@users.noreply.github.com>
@yaroslavborbat yaroslavborbat requested a review from diafour June 3, 2026 11:10
@yaroslavborbat yaroslavborbat modified the milestones: v1.8.3, v1.9.0 Jun 3, 2026
@nevermarine nevermarine modified the milestones: v1.8.3, v1.9.0 Jun 3, 2026
@yaroslavborbat yaroslavborbat merged commit d101ce7 into main Jun 3, 2026
29 of 32 checks passed
@yaroslavborbat yaroslavborbat deleted the fix/vlctl-domain branch June 3, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diafour diafour diafour approved these changes
@universal-itengineer universal-itengineer Awaiting requested review from universal-itengineer universal-itengineer is a code owner
@nevermarine nevermarine Awaiting requested review from nevermarine nevermarine is a code owner

Assignees

@yaroslavborbat yaroslavborbat

Labels

None yet

Projects

None yet

Milestone

v1.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@yaroslavborbat @diafour @nevermarine