Skip to content

fix(vm): choose correct active pod#967

Merged
yaroslavborbat merged 3 commits into
mainfrom
fix/vm/active-pod
Apr 23, 2025
Merged

fix(vm): choose correct active pod#967
yaroslavborbat merged 3 commits into
mainfrom
fix/vm/active-pod

Conversation

@yaroslavborbat
Copy link
Copy Markdown
Member

@yaroslavborbat yaroslavborbat commented Apr 23, 2025

Description

Сhoose correct active pod
In some cases, we display an incorrect active pod for a VM. For example,
if there was a migration via vmop and it failed, the VM status will show an incorrect pod as active.

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vm
type: fix
summary: Choose a correct active pod to show in the VM status
impact_level: low

@yaroslavborbat yaroslavborbat modified the milestones: v0.18.0, v0.17.0 Apr 23, 2025
@yaroslavborbat yaroslavborbat marked this pull request as ready for review April 23, 2025 10:06
@yaroslavborbat yaroslavborbat requested a review from Isteb4k as a code owner April 23, 2025 10:06
@yaroslavborbat yaroslavborbat added the e2e/run Run e2e test on cluster of PR author label Apr 23, 2025
@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Apr 23, 2025
@yaroslavborbat yaroslavborbat requested a review from diafour April 23, 2025 11:04
Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>
Comment thread images/virtualization-artifact/pkg/controller/vm/internal/statistic_test.go Outdated
Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>
diafour
diafour previously approved these changes Apr 23, 2025
Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>
@yaroslavborbat yaroslavborbat merged commit daf475f into main Apr 23, 2025
22 of 23 checks passed
@yaroslavborbat yaroslavborbat deleted the fix/vm/active-pod branch April 23, 2025 14:19
yachmenevas pushed a commit that referenced this pull request Oct 15, 2025
Сhoose correct active pod
---------
Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants