Finding
File: tests/test_reaggregate.py:145
Severity: Minor
Source: Code review of PR #290
Issue
The round-trip test in test_reaggregate.py omits triage_calibration and file_prediction_accuracy from the roundtrip_metrics list. Both metrics populate sample_scores and should round-trip correctly (i.e. the mean of per-session scores should match the engine aggregate). As-is, they are silently untested.
Suggested Fix
Add "triage_calibration" and "file_prediction_accuracy" to the roundtrip_metrics list at tests/test_reaggregate.py:145. The existing if metric_name not in report.aggregate_scores: continue guard already handles the case where test samples lack data for these metrics, so no additional changes are needed.
References
Finding
File:
tests/test_reaggregate.py:145Severity: Minor
Source: Code review of PR #290
Issue
The round-trip test in
test_reaggregate.pyomitstriage_calibrationandfile_prediction_accuracyfrom theroundtrip_metricslist. Both metrics populatesample_scoresand should round-trip correctly (i.e. the mean of per-session scores should match the engine aggregate). As-is, they are silently untested.Suggested Fix
Add
"triage_calibration"and"file_prediction_accuracy"to theroundtrip_metricslist attests/test_reaggregate.py:145. The existingif metric_name not in report.aggregate_scores: continueguard already handles the case where test samples lack data for these metrics, so no additional changes are needed.References