Conversation
Remove 3 unused-ignore-comment suppressions in llm_setup.py. The
underlying type issue for llm.model_args.pop has been resolved by ty
version updates, so the three suppress comments on that call (google
branch, litellm branch, and anthropic fall-through) are now stale.
Stale comments removed (lines 123, 140, 160 in original file):
llm.model_args.pop("top_p", None) # ty: ignore[unresolved-attribute]
The 4 remaining ty: ignore[unresolved-attribute] comments (lines 39,
50, 63, 74) and all ty: ignore[unresolved-import] comments are kept
as they still suppress real unresolved-attribute errors.
Also stale after ty updates — jinja2 import now resolves cleanly. Assisted-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove 3 stale
# ty: ignore[unresolved-attribute]comments inllm_setup.pythat triggerunused-ignore-commentwarnings on every commit.Test plan
uv run ty check src/raki/— 0unused-ignore-commentwarningsuv run pytest tests/ -v -m "not slow"— no regressionsRefs #222
🤖 Generated with Claude Code via SODA pipeline