Conversation
Add tests to TestPhaseTimelineDotColoring covering all verdict×status combinations described in the plan: - verify PASS + completed → green dot - verify FAIL + completed → red dot (currently fails — bug) - verify PASS + failed/skipped/superseded → status wins - review approve/pass/pass-with-follow-ups → green dot - review REWORK + completed → yellow dot (currently fails — bug) - review FAIL + completed → red dot (currently fails — bug) - review REWORK + failed → status wins (red) - non-verify/review phase gen>1 preserves rework logic Also extend _make_report_with_phases helper to accept output_structured per phase entry.
…hases Replace the single-line dot_class expression (line 1384) with a multi-branch block that checks verdict from output_structured before falling back to the existing generation-based logic. Priority rules: - failed/skipped/superseded status always wins over any verdict - verify phases: PASS verdict → green (completed), else → red (failed) - review phases: approve/pass/pass-with-follow-ups → green, REWORK → yellow (rework), else → red (failed) - all other phases: gen>1 completed → yellow (rework), else status All CSS classes (phase-status-completed, phase-status-rework, phase-status-failed, phase-status-skipped, phase-status-superseded) already existed — no style changes required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase status dots in the HTML report now correctly reflect the structured verdict for
verifyandreviewphases, rather than relying solely on execution status.Previously, a
verifyphase that completed execution successfully (status =completed) but with aFAILverdict would show a green dot. Similarly, areviewphase with verdictREWORKshowed a green dot. This misled users into thinking everything was fine when it wasn't.Changes
Template (
src/raki/report/templates/report.html.j2): Replaced the singledot_classexpression with a multi-branch block implementing priority rules:failed/skipped/superseded) always win over any verdictverifyphase with structured verdict:PASS→ green, else → redreviewphase with structured verdict:approve/pass/pass-with-follow-ups→ green,REWORK→ yellow, else → redTests (
tests/test_report_html.py): Added 12 new tests inTestPhaseTimelineDotColoringcovering all verdict×status combinations including edge cases where execution status overrides verdict.Changelog (
changes/325.fix): Towncrier fragment added.Acceptance Criteria
verifyphase with verdictFAILand statuscompletedshows a red dotverifyphase with verdictPASSand statuscompletedshows a green dotreviewphase with verdictREWORKand statuscompletedshows a yellow dotreviewphase with verdictapprove/pass/pass-with-follow-upsshows a green dotreviewphase with verdictFAILshows a red dotfailed/skipped/superseded) take priority over any verdictReview Results
Refs #325
Assisted-by: Claude Opus 4.6 (1M context) noreply@anthropic.com
Assigned-by: decko