Conversation
…rage in TestPhaseTimelineDotColoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verifies that skipped phases render with the muted
phase-status-skippedCSS class in the phase timeline dot component.Two tests in
TestPhaseTimelineDotColoringcover the skipped-phase path:test_skipped_phase_has_skipped_dot— a monitor phase withstatus=skippedrenders thephase-status-skippedCSS class.test_verify_pass_verdict_but_skipped_status_gives_skipped_dot— skipped execution status takes priority over a PASS verdict on the verify phase.Both tests were already present in the codebase (landed in prior commits). This ticket adds the towncrier changelog fragment documenting the coverage.
Acceptance Criteria
test_skipped_phase_has_skipped_dotexists and passes inTestPhaseTimelineDotColoringtest_verify_pass_verdict_but_skipped_status_gives_skipped_dotexists and passes inTestPhaseTimelineDotColoringTestPhaseTimelineDotColoringtests passchanges/272.misccreated and committedSpecialist Review Results
Implementation
changes/272.misc), 1 commit (da61c4d)Verification
Review
Refs #272
Assisted-by: Claude Opus 4.6 (1M context) noreply@anthropic.com
Assigned-by: decko