fix(github): improve callTool response handling#386
Merged
Conversation
…ured content support Handle isError responses by throwing, prefer structuredContent when available, and fail explicitly when text content cannot be parsed as JSON. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
result.isErrorby throwing with the text message or a fallbackresult.structuredContentdirectly when availablesafeJsonParsehelper for safe JSON parsingTest plan
🤖 Generated with Claude Code
Summary by cubic
Improves callTool response handling in the GitHub MCP proxy. Throws on upstream errors, prefers
structuredContent, and parses text responses as JSON with clear failures.result.isErroris true.result.structuredContentdirectly when available.Failed to parse: <msg>.safeJsonParsehelper and remove response logs.Written for commit 67a5913. Summary will update on new commits.