fix(bindings): remove early return in isImplementedBy loop#2085
Merged
viktormarinho merged 1 commit intomainfrom Dec 23, 2025
Merged
fix(bindings): remove early return in isImplementedBy loop#2085viktormarinho merged 1 commit intomainfrom
viktormarinho merged 1 commit intomainfrom
Conversation
viktormarinho
force-pushed
the
fix/binding-checker-early-return
branch
from
a8f106c to
9c817ac
Compare
mcandeia
approved these changes
Dec 23, 2025
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
The isImplementedBy function was returning true after finding the first matching tool, instead of checking all required tools in the binding. This caused false positives when only some required tools were present.
viktormarinho
force-pushed
the
fix/binding-checker-early-return
branch
from
9c817ac to
255ca01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createBindingCheckerwhereisImplementedBy()returnedtrueafter finding the first matching tool, instead of checking all required tools in the binding[A, B, C]but onlyAexists → incorrectly returnedtrue)Test plan
bun test packages/bindings)return true;statement inside the for loopSummary by cubic
Removed the early return in createBindingChecker’s isImplementedBy so it checks all required tools before returning true. This prevents false positives when a binding requires multiple tools but only some exist.
Written for commit 255ca01. Summary will update automatically on new commits.