Conversation
…tems - Added `findOrFirst` helper function to retrieve stored items or fallback to the first item in the array. - Introduced `useStoredSelection` hook to manage selected models and gateways using local storage. - Refactored `ChatPanelContent` to utilize the new hook for improved state management of selected items. - Enhanced dynamic system prompt generation based on selected gateway.
…mponents - Added error handling capabilities with `ChatErrorBanner` to display errors and provide options to fix them directly in the chat interface. - Introduced `limits` property in model configuration to manage context window and output token limits. - Updated `ChatBranchPreview` to utilize a reusable `ChatHighlight` component for better UI consistency. - Refactored `ChatPanelContent` to include error handling and model limits in the request payload. - Enhanced `usePersistedChat` hook to manage chat errors and provide a clear error state.
…r handling - Introduced `ChatFinishReasonWarning` component to inform users about incomplete responses and provide options to continue. - Updated `Chat` component to include the new warning feature. - Enhanced `ChatPanelContent` and `AssistantChatPanelContent` to display the finish reason warning alongside error handling. - Modified `usePersistedChat` hook to manage finish reason state, improving user experience during chat interactions.
Contributor
🧪 BenchmarkShould we run the MCP Gateway benchmark for this PR? React with 👍 to run the benchmark.
Benchmark will run on the next push after you react. |
Contributor
Release OptionsShould a new version be published when this PR is merged? React with an emoji to vote on the release type:
Current version: Deployment
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 8 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/mesh/src/web/components/chat/index.tsx">
<violation number="1" location="apps/mesh/src/web/components/chat/index.tsx:246">
P2: Icon-only button needs `aria-label` for screen reader accessibility. The `title` attribute alone is not reliably announced by assistive technologies.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
tlgimenes
force-pushed
the
chore/chat-errors
branch
from
f43a7c9 to
a42abdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR surfaces chat errors/warnigns and info