fix(multi-pod): pin STUDIO_SANDBOX_RUNNER=docker to unblock attach-cross-pod#3436
Merged
Conversation
…nk-gated Without an explicit runner the env defaults to "remote-user", and resolveDispatchTarget then 409s with link_offline because CI doesn't run a link daemon. PR #3434 removed the eager ensureVm() but left the dispatch check in place, so attach-cross-pod still failed at POST /messages. Pinning to "docker" makes resolveDispatchTarget short-circuit to the local cluster default; no sandbox is actually provisioned because ensureVm is lazy and the mock-ai scenario never emits tool calls. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this contribution about?
Fixes the
attach-cross-podmulti-pod CI failure wherePOST /api/:org/decopilot/threads/:id/messagesreturned409 link_unavailable / link_offline(see failing job).Root cause:
tests/multi-pod/docker-compose.ymldidn't setSTUDIO_SANDBOX_RUNNER, soresolveSandboxProviderKindFromEnv()defaulted to"remote-user". With no link daemon registered in CI,resolveDispatchTargetrejected the request before it could enqueue. PR #3434 removed the eagerensureVm()(which had been 500-ing) but the dispatch check that gates on link presence stayed, so the symptom shifted from 500 → 409 without fully fixing the test.Pinning
STUDIO_SANDBOX_RUNNER=dockeron the mesh services makesresolveDispatchTargetshort-circuit to the local cluster default (no link check), and no real sandbox is provisioned becauseensureVmis lazy (built-in-tools/index.ts:159-184) and the mock-AI scenario never emits tool calls.How to Test
./tests/multi-pod/run.sh.attach-cross-podshould pass (along with the rest of the suite).Summary by cubic
Pins
STUDIO_SANDBOX_RUNNER=dockerintests/multi-pod/docker-compose.ymlto fixattach-cross-podfailing with 409link_offlineonPOST /api/:org/decopilot/threads/:id/messages. This forces local dispatch and avoids any sandbox provisioning sinceensureVmis lazy.dockershort-circuits to the local cluster and unblocks the test.Written for commit baf57c5. Summary will update on new commits. Review in cubic