DE-6354: Add Kafka-Iceberg with Flink example code #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rmoff
commented
Jul 2, 2024
rmoff
commented
- Updates
- update
- Added readme, sample SQL files, fixed deps, etc
- Update readme
Contributor
gunnarmorling
left a comment
gunnarmorling
left a comment
There was a problem hiding this comment.
LGTM overall. A few suggestions inline.
|
|
||
| `@rmoff 2024-07-02` | ||
|
|
||
| _👉 See the supporting blog post at https://www.decodable.co/blog/_ |
Contributor
There was a problem hiding this comment.
Can we have a sentence here which describes that example on a high level. Referring to the blog post is good, but it would be nice to make the example also self-contained to some degree.
Contributor
Author
There was a problem hiding this comment.
the title of the readme is Streaming data from Kafka to Iceberg with Apache Flink so I think is complete as it stands.
gunnarmorling
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.