Adding support for AArch64 #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmoff
approved these changes
Sep 12, 2024
gunnarmorling
commented
Sep 12, 2024
Contributor
Author
|
@jbreeden, could you ping here once the Arm CLI release is out? Thx! |
gunnarmorling
commented
Sep 13, 2024
Contributor
|
I already merged cli-docker into main; do you want to do another PR for
this change?
…--
Robin Moffatt
Principal DevEx Engineer, Decodable
On Fri, 13 Sept 2024 at 16:25, Gunnar Morling ***@***.***> wrote:
Merged #24 <#24> into
cli-docker.
—
Reply to this email directly, view it on GitHub
<#24 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4AMHSMHON77DSHBAKSMSLZWL7VNAVCNFSM6AAAAABODNLKKWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGI2TANRUG44DIMI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
Author
|
Ah, whoops, good spot. Given you've approved this PR already, I've taken the liberty and just pushed this commit to main. Thx for bringing this up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rmoff, this adds the native support for Arm to your pending PR. Note it requires https://github.com/decodableco/decodable/pull/3818 to be merged first and a release cut from it.