Skip to content

fix(vton-modal): close button alignment in panel header (#602)#607

Merged
thxforall merged 1 commit into
devfrom
fix/602-vton-modal-close-button-alignment
May 28, 2026
Merged

fix(vton-modal): close button alignment in panel header (#602)#607
thxforall merged 1 commit into
devfrom
fix/602-vton-modal-close-button-alignment

Conversation

@thxforall
Copy link
Copy Markdown
Contributor

Summary

X 버튼이 modal root에 absolute top-4 right-4 floating button으로 떠 있어 ItemPanel 헤더의 "Virtual Try-On PoC" 텍스트와 vertical 정렬되지 않던 문제 해결.

Changes

  • packages/web/lib/components/vton/VtonModal.tsx
    • floating <button> (line 365-371) 제거
    • 사용 안 하는 import { X } from "lucide-react" 제거
    • <VtonItemPanel ... onClose={handleClose} /> prop 전달
  • packages/web/lib/components/vton/VtonItemPanel.tsx
    • Props 인터페이스에 onClose: () => void 추가
    • 헤더 div를 flex items-center justify-between border-b border-white/10 px-4 py-3로 변경
    • 헤더 우측에 X 버튼 통합 (aria-label="Close VTON modal" 유지 — E2E selector 호환)

Verification

  • bun run lint → 0 errors (<img> warning은 pre-existing, 본 PR 비관련)
  • bun run tsc --noEmit → 0 errors (vton files)
  • bun run build → PASS
  • handleClose / Escape key / backdrop click 동작 그대로 유지

Test plan

  • VTON 모달 열고 X 버튼이 "Virtual Try-On PoC" 텍스트와 같은 vertical-center에 정렬되는지 확인
  • X 버튼 클릭으로 모달 닫힘 확인
  • Escape 키로 모달 닫힘 확인
  • backdrop 영역 클릭으로 모달 닫힘 확인
  • 모바일 viewport(@media md:)에서도 동일 동작 확인

⚠️ Heads-up — bun run build failure is NOT this PR

Local bun run buildpackages/web/app/api/v1/content/assets/plan/__tests__/route.test.ts:559useResearchInCopy 타입 mismatch로 실패합니다. 이는 dev pre-existing: #498 (feat(content-studio): AI-powered content generation pipeline) 머지된 시점부터 발생. 본 PR은 vton 파일만 건드리고 vton 한정 lint/tsc/test는 모두 PASS. content-studio 영역 fix는 별도 owner가 처리해야 함.

Refs #602 (sub-PR #1 of 4)

X 버튼이 modal root의 floating button으로 떠 있어 헤더 텍스트와
정렬되지 않던 문제를 ItemPanel 헤더에 통합하여 해결.

Refs #602 (sub-PR #1)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
decoded-app Error Error May 28, 2026 10:42am

@thxforall thxforall moved this from Todo to In Progress in decoded-monorepo May 28, 2026
@thxforall thxforall added the bump:patch Bug fixes / internal refactor label May 28, 2026
@thxforall thxforall merged commit 1004a89 into dev May 28, 2026
8 of 11 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in decoded-monorepo May 28, 2026
@thxforall thxforall deleted the fix/602-vton-modal-close-button-alignment branch May 28, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bump:patch Bug fixes / internal refactor

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant