Skip to content

Conversation

@amihaiemil
Copy link
Member

@amihaiemil amihaiemil commented Mar 18, 2020

fixes #200

  • turned Scalar into an interface.
  • BuiltPlainScalar for building YAML scalars
  • ReadPlainScalarValue for reading Scalar values from a mapping or a sequence
  • ReadPlainScalarKey for reading a plain Scalar key from a mapping.
  • ReadFoldedBlockScalar and ReadLiteralBlockScalar

@coveralls
Copy link

coveralls commented Mar 18, 2020

Pull Request Test Coverage Report for Build 426

  • 72 of 74 (97.3%) changed or added relevant lines in 15 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.7%) to 91.809%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/amihaiemil/eoyaml/AllYamlLines.java 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/amihaiemil/eoyaml/AllYamlLines.java 2 69.23%
Totals Coverage Status
Change from base Build 414: 0.7%
Covered Lines: 863
Relevant Lines: 940

💛 - Coveralls

@amihaiemil
Copy link
Member Author

@rultor merge it

@rultor
Copy link
Collaborator

rultor commented Mar 22, 2020

@rultor merge it

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 95a4860 into master Mar 22, 2020
@rultor
Copy link
Collaborator

rultor commented Mar 22, 2020

@rultor merge it

@amihaiemil Done! FYI, the full log is here (took me 2min)

@amihaiemil amihaiemil deleted the 200 branch March 22, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scalar should be an Interface

4 participants