chainec/dcrec: Remove hybrid pubkey support#1155
Merged
davecgh merged 2 commits intodecred:masterfrom Mar 22, 2018
Merged
Conversation
Hybrid pubkeys, which are a relic of OpenSSL used in Bitcoin Core, are not usable with OP_CHECKSIG and we can potentially prevent creating unspendable outputs by never allowing the creation of P2PK (or derived P2PKH) addresses for these pubkeys.
This is a follow-up to a previous change which removed the ability to create a dcrutil.Address from a hybrid pubkey. It removes all secp256k1 hybrid pubkey support from the chainec/dcrec packages since these pubkeys are not usable when evaluated by OP_CHECKSIG or OP_CHECKMULTISIG. While ParsePubKey is called by consensus code and its behavior has been changed to error when encountering a hybrid secp256k1 pubkey, this is not a consensus change as every use of ParsePubKey in consensus code either checks beforehand that the pubkey is compressed or uncompressed, requires a parsed address to be P2PKH or P2SH, or checks an address string against the premine ledger (which only contains P2PKH addresses).
davecgh
approved these changes
Mar 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #1154
This is a follow-up to a previous change which removed the ability to
create a dcrutil.Address from a hybrid pubkey. It removes all
secp256k1 hybrid pubkey support from the chainec/dcrec packages since
these pubkeys are not usable when evaluated by OP_CHECKSIG or
OP_CHECKMULTISIG.
While ParsePubKey is called by consensus code and its behavior has
been changed to error when encountering a hybrid secp256k1 pubkey,
this is not a consensus change as every use of ParsePubKey in
consensus code either checks beforehand that the pubkey is compressed
or uncompressed, requires a parsed address to be P2PKH or P2SH, or
checks an address string against the premine ledger (which only
contains P2PKH addresses).