dcrjson: Add VerifySeedCmd.#1160
Merged
davecgh merged 3 commits intodecred:masterfrom Mar 30, 2018
githubsands:master
Merged
Conversation
Member
|
Can you please bump the copyright years to 2018 in each file modified? |
Contributor
Author
|
Yeah give me a bit |
davecgh
changed the title
davecgh
requested changes
Mar 30, 2018
dcrjson/walletsvrcmds.go
Outdated
|
|
||
| // VerifySeedCmd defines the verifyseed JSON-RPC command. | ||
| type VerifySeedCmd struct { | ||
| Seed string `json:"seed"` |
Member
There was a problem hiding this comment.
Commands should not have the json field name overrides because they are positional. Take a look at all of the other type XCmd struct definitions and notice that none of them do so.
davecgh
changed the title
davecgh
approved these changes
Mar 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes needed for [decred/dcrwallet#1037]
dcrjson/walletsvrcmds.godcrjson/walletsvrcmds_test.godcrjson/walletsvrresults.gorpcserver.go