txscript: Support min int64 script num encoding.#2863
Merged
davecgh merged 1 commit intodecred:masterfrom Jan 7, 2022
Merged
Conversation
This modifies the encoding logic for script numbers to support encoding min int64s. This was previously not supported since the type was not public and it is not possible to achieve a min int64 within the context of the script system itself due to the strict limits it imposes. However, now that script numbers are exported for external use and callers are not bound by the aforementioned strictness, it should be possible to encode the entire range for completeness. In practice, callers should never realistically need to encode the value since the purpose of the type is to create encoded numbers for scripts and the value in question will be rejected upon any attempt to use it as a number when verifying scripts given it is out of range.
rstaudt2
approved these changes
Jan 1, 2022
dnldd
approved these changes
Jan 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies the encoding logic for script numbers to support encoding min
int64s. This was previously not supported since the type was not public and it is not possible to achieve a minint64within the context of the script system itself due to the strict limits it imposes.However, now that script numbers are exported for external use and callers are not bound by the aforementioned strictness, it should be possible to encode the entire range for completeness.
In practice, callers should never realistically need to encode the value since the purpose of the type is to create encoded numbers for scripts and the value in question will be rejected upon any attempt to use it as a number when verifying scripts given it is out of range.