edwards: More strict pubkey parsing.#2869
Merged
davecgh merged 1 commit intodecred:masterfrom Jan 14, 2022
Merged
Conversation
matheusd
reviewed
Jan 13, 2022
This modifies the public key parsing method to make it more strict by rejecting public keys that are not exactly the required length as opposed to silently truncating or padding them and adds tests accordingly. This helps prevent misuse by callers and makes it behave more consistently with the secp256k1 public key parsing. Note that this does not affect consensus code since the only place it is called is during the signature verification opcode where the consensus rules ensure the the key is the correct length before parsing it.
davecgh
force-pushed
the
edwards_more_strict_pubkey_parse
branch
from
525a5d8 to
79f15b7
Compare
matheusd
approved these changes
Jan 13, 2022
dnldd
approved these changes
Jan 13, 2022
rstaudt2
approved these changes
Jan 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies the public key parsing method to make it more strict by rejecting public keys that are not exactly the required length as opposed to silently truncating or padding them and adds tests accordingly.
This helps prevent misuse by callers and makes it behave more consistently with the
secp256k1public key parsing.Note that this does not affect consensus code since the only place it is called is during the signature verification opcode where the consensus rules ensure the the key is the correct length before parsing it.
Closes #2857.