mining: Wait for initial sync to generate template.#2897
Merged
davecgh merged 1 commit intodecred:masterfrom Mar 13, 2022
Merged
mining: Wait for initial sync to generate template.#2897davecgh merged 1 commit intodecred:masterfrom
davecgh merged 1 commit intodecred:masterfrom
Conversation
davecgh
force-pushed
the
mining_wait_for_initial_sync
branch
from
dedea29 to
875b4de
Compare
dajohi
approved these changes
Mar 9, 2022
Member
dajohi
left a comment
dajohi
left a comment
There was a problem hiding this comment.
Thanks for tracking this down.
rstaudt2
approved these changes
Mar 13, 2022
Currently, when the server is started with a chain that is already synced, a new block template will not be generated until either a new template is forced to be generated via the regentemplate RPC or a new block is connected. In practice, the most observable consequence is that getwork won't return results right away when restarting the server when the chain is already synced until either of the aforementioned cases happened which makes it appear as if it is hung. This resolves that by modifying the logic of the background block template generator to wait for the initial chain sync to complete prior to attempting to generate the first template unless unsynced mining is allowed.
davecgh
force-pushed
the
mining_wait_for_initial_sync
branch
from
875b4de to
5d8df9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when the server is started with a chain that is already synced, a new block template will not be generated until either a new template is forced to be generated via the
regentemplateRPC or a new block is connected.In practice, the most observable consequence is that
getworkwon't return results right away when restarting the server when the chain is already synced until either of the aforementioned cases happened which makes it appear as if it is hung.This resolves that by modifying the logic of the background block template generator to wait for the initial chain sync to complete prior to attempting to generate the first template unless unsynced mining is allowed.