secp256k1/ecdsa: Consistent sig recovery errors.#2914
Merged
davecgh merged 1 commit intodecred:masterfrom Apr 7, 2022
Merged
Conversation
davecgh
force-pushed
the
secp256k1_consistent_compact_sig_errs
branch
from
a4f479c to
a5b3e5d
Compare
dnldd
approved these changes
Apr 5, 2022
dajohi
approved these changes
Apr 6, 2022
JoeGruffins
approved these changes
Apr 7, 2022
rstaudt2
approved these changes
Apr 7, 2022
This converts the error handling in compact signature recovery to be consistent with the rest of the code base such that it returns concrete errors that support errors.Is/As and thus are programmatically detectable by callers.
davecgh
force-pushed
the
secp256k1_consistent_compact_sig_errs
branch
from
a5b3e5d to
d205e99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This converts the error handling in compact signature recovery to be consistent with the rest of the code base such that it returns concrete errors that support errors.Is/As and thus are programmatically detectable by callers.