mempool: Use valid tx fees in test harness.#2962
Merged
davecgh merged 1 commit intodecred:masterfrom Jun 28, 2022
Merged
Conversation
dnldd
approved these changes
Jun 21, 2022
davecgh
added
the
test coverage
This modifies the test harness to create transactions that use valid fees instead of zero fees and cleans up a couple of minor things in the process. Of particular note is TestMaybeAcceptTransactions which was reworked to use the existing transaction chain generation func and calculate the expected ancestor fees from the transactions instead of manually overriding.
davecgh
force-pushed
the
mempool_use_valid_fees_in_test_harness
branch
from
079098e to
db05fd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies the test harness to create transactions that use valid fees instead of zero fees and cleans up a couple of minor things in the process.
Of particular note is
TestMaybeAcceptTransactionswhich was reworked to use the existing transaction chain generation func and calculate the expected ancestor fees from the transactions instead of manually overriding.