dcrutil: Correct off-by-1 index check.#2991
Merged
davecgh merged 1 commit intodecred:masterfrom Aug 30, 2022
Merged
Conversation
davecgh
approved these changes
Aug 28, 2022
Member
davecgh
left a comment
davecgh
left a comment
There was a problem hiding this comment.
Thanks for the PR. Good catch!
I don't really expect it will ever be used and I'm really not even sure why it was added, but since it's there, I agree that it should be correct.
As a bit of an aside, ultimately, the plan is to entirely remove dcrutil.Block and dcrutil.Tx as discussed a bit in #2786.
davecgh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I was reading through this section of the code when I noticed what seems to be a 1-off issue,
even though I couldn't find the affected
funcsbeing used indcrdcode-base (besides tests), I assume: