txscript: remove obsolete requireMinimal comment#3004
Merged
davecgh merged 1 commit intodecred:masterfrom Sep 29, 2022
Merged
Conversation
davecgh
approved these changes
Sep 29, 2022
davecgh
reviewed
Sep 29, 2022
The requireMinimal flag for MakeScriptNum was removed in 84b65d0 but the description was left in the comment for MakeScriptNum. This removes that part of the docs. Also expand on range error and fix code reference. In d8306ee, the error for out-of-range changed from ErrNumberTooBig to ErrNumOutOfRange.
chappjc
force-pushed
the
require-minimal-rm
branch
from
8600e5a to
11a2f01
Compare
davecgh
approved these changes
Sep 29, 2022
dnldd
approved these changes
Sep 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The requireMinimal flag for MakeScriptNum was removed in 84b65d0 but the description was left in the comment for MakeScriptNum. This removes that part of the docs.