secp256k1: Add GeneratePrivateKeyFromRand tests.#3100
Merged
davecgh merged 1 commit intodecred:masterfrom Apr 13, 2023
Merged
Conversation
jrick
approved these changes
Apr 13, 2023
Member
jrick
left a comment
jrick
left a comment
There was a problem hiding this comment.
no test that the func panics when passing nil? 😝
This adds tests for the newly added GeneratePrivateKeyFromRand func to restore test coverage. It also takes advantage of the ability to specify the random source to inject faults to improve the test coverage of private key generation in general to achieve 100% branch coverage.
davecgh
force-pushed
the
secp256k1_genprivkey_tests
branch
from
55f8d8b to
6c5b953
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds tests for the newly added
GeneratePrivateKeyFromRandfunc to restore test coverage.It also takes advantage of the ability to specify the random source to inject faults to improve the test coverage of private key generation in general to achieve 100% branch coverage.