Merged
Conversation
davecgh
requested changes
Dec 23, 2017
txscript/opcode_test.go
Outdated
Member
There was a problem hiding this comment.
Seems like an extra tab snuck in here.
txscript/opcode_test.go
Outdated
davecgh
requested changes
Dec 23, 2017
txscript/opcode.go
Outdated
Member
There was a problem hiding this comment.
This would introduce a hard fork. It needs to remain opcodeInvalid.
In fact, I would suggest this should be named OP_INVALID249 to make this clear. It should also be kept in the section with the comment as the reason for it being reserved/invalid did not change.
Member
Author
There was a problem hiding this comment.
Will be sure to assert modifications to upstream commits before putting up a PR. Sorry about that.
dnldd
force-pushed
the
merge_removesmalldata
branch
2 times, most recently
from
7631065 to
b300e7a
Compare
davecgh
reviewed
Dec 29, 2017
txscript/opcode_test.go
Outdated
Member
There was a problem hiding this comment.
There appears to be an extra tab here.
davecgh
requested changes
Dec 29, 2017
txscript/opcode_test.go
Outdated
Member
There was a problem hiding this comment.
There is no need to do this. Instead, just replace the 0xf9 entry in the map with OP_INVALID249.
txscript/opcode_test.go
Outdated
dnldd
force-pushed
the
merge_removesmalldata
branch
from
b300e7a to
e44f635
Compare
dnldd
force-pushed
the
merge_removesmalldata
branch
from
e44f635 to
e582881
Compare
davecgh
approved these changes
Dec 29, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following upstream commits:
TestOpcodeDisasmOP_UNKNOWN#range checks.