client: Fix login redirect loop.#3571
Merged
JoeGruffins merged 10 commits intodecred:masterfrom Mar 19, 2026
Merged
Conversation
When a DEX account is disabled, the trade page now shows the DEX disabled message with a link to the settings page instead of the generic "Connection to server failed / Waiting to reconnect" overlay.
Token wallets (e.g. usdc.eth, polygon.eth) were not themselves marked disabled when only their parent chain wallet was disabled, causing error log spam on startup when the parent connection was refused.
JoeGruffins
force-pushed
the
alldisabled
branch
2 times, most recently
from
43ecd5f to
90f4aca
Compare
martonp
reviewed
Mar 18, 2026
client/asset/eth/eth.go
Outdated
| // Use the relay's network fee values for tip extraction to avoid | ||
| // mismatches from different RPC providers. Fall back to local values | ||
| // if the relay doesn't provide them. | ||
| baseFee, tipRate := estimate.BaseFee, estimate.TipCap |
Collaborator
There was a problem hiding this comment.
The reason for this code was to ensure that the relay was not charging an unreasonable tip. If the client is blindly trusting the relay's fee rates, then it kind of defeats the purpose.
Member
Author
There was a problem hiding this comment.
Ok. Was unable to use the relay on mainnet polygon. Ill extract this into a different pr, sorry just in a hurry to get fixes in.
JoeGruffins
force-pushed
the
alldisabled
branch
from
7187959 to
cf1c516
Compare
Avoids error log during shutdown.
When loadPage fetches a page but receives the login page instead (due to a server-side auth redirect), fall back to a full browser navigation rather than silently inserting the login page HTML. The browser's navigation handles cookie state more reliably than fetch.
The v8 DB upgrade used raw market names from the DB (e.g. dcr_usdt.eth) which contain dots from token symbols. The actual PostgreSQL schema names replace dots with TKN via marketSchema(). Apply that conversion before constructing the table name for the ALTER TABLE statement.
Disabled wallets were shown in the network selector when requesting a receive address, leading to a broken address screen. Filter them out so only enabled wallets are selectable.
Correct the server upgrade guidance: all in-flight swaps from v1.0.x are revoked on upgrade due to the per-match address requirement, so operators must wait for active swaps to complete. The previous advice about evm-protocol-overrides.json is insufficient on its own. Add known issues section noting that Electrum wallets are temporarily disabled due to inconsistencies found during testing, with a fix expected in a patch release.
The dcrdata /tx/{txid}/out/{vout} path now returns 403. Link to the
transaction page instead, consistent with other UTXO assets.
Three locale keys were split across lines in the template, preventing the [[[...]]] replacement from matching: "pick a different asset", "Authorize Import", and "Wallet Balances".
When mixing is disabled but the mixed or trading accounts exist from a previous mixing session, their balances were invisible. Now those funds are reported as locked so the user can see they still exist. Ticket values in those accounts are also included in the staked category.
JoeGruffins
force-pushed
the
alldisabled
branch
from
cf1c516 to
a5ca45c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.