fix(callback): callback was called twice when lib was already loaded#72
Merged
ded merged 1 commit intoded:masterfrom Jul 11, 2014
Merged
fix(callback): callback was called twice when lib was already loaded#72ded merged 1 commit intoded:masterfrom
ded merged 1 commit intoded:masterfrom
Conversation
Contributor
Author
|
@ded Do you think this PR will take long to be merged? I didn't explain the bug clearly. Lets say you do: $script(['foo.js', 'bar.js'], doSomething) and afterwards you do $script(['foo.js', 'bar.js', 'baz.js'], doSomethingElse) doSomethingElse may be called before 'baz.js' has been loaded and executed. Thank you! |
Owner
|
i see now. thanks for the test. let me make sure it didn't break any other edge cases |
ded
added a commit
that referenced
this pull request
Jul 11, 2014
fix(callback): callback was called twice when lib was already loaded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When $script was used with lists with shared scripts, the inside
callback()was called twice for previously loaded libraries, and this caused thedone()to be called before the scripts were loaded.Side bonus: 21 bytes less in minified library