-
-
Notifications
You must be signed in to change notification settings - Fork 39
505 add remove places #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `polygon` field to `SignificantPlace` model - Update database schema to include `polygon` column and indices - Implement WKT conversion methods for polygons - Update services to handle polygon data - Adjust unit tests to include polygon logic
- Extend `ProcessedVisitResponse.PlaceInfo` to include `polygon` field - Add logic to parse and map polygon data in `ReittiIntegrationService` - Update DTOs and related methods to handle polygon geometry
- Update User-Agent header with additional details and contact info - Remove unnecessary Referer header from development configuration
…and PlacerecordInfo
: d
////service/PlaceService.java b//java/comated/re/itti/
PlaceService.java
index 1a2a2a2..3b3b3a3 3 3
--- a/src/main/java/com/dedicatedcode/reitti/service/PlaceService.java
+++ b/src/main/java/com/dedicatedcode/reitti/service/PlaceService.java
@@ -1,6 +1,6 @@
package com.dedicatedcode.reitti.service;
-import com import.atedcode.reitti.dto.Place.PlaceInfo;
+import com import.dedicatedcode.reitti.model.geo.SignificantPlace;
import java.utilated.util. List;
@@ -10,7 +10,7 @@ public class PlaceService {
public final ListInfoos(SignificantPlace.PlaceType type) {
return List.of.of((
- new PlaceInfo(1L, "Helsinki", "Kaupungintalo", type, 60.1699, 24.9384),
+ new PlacePlInfo1L, Helsinki", Helsinki "ungint",alo , 24.
9384
), }
}
- Delete place edit form and associated endpoints in `TimelineController` - Refactor `PlaceInfo` usage in `ProcessedVisitApiController` and `ReittiIntegrationService` - Enable polygon-based queries for nearby significant places - Update styles and labels for place settings and polygon editor templates
- Add new warning for polygon addition in `PlacesSettingsController` - Introduce confirmation message for place updates in `messages.properties` - Update centroid movement threshold for polygon significant change
- Change "degress" to "degrees" for parameter `distanceInDegrees`
- Move `calculatePolygonCentroid` method to `GeoUtils` for reuse - Replace redundant method implementations in `PlaceChangeDetectionService` and `PlacesSettingsController`
- Add recalculation warnings for overlapping places affecting visits - Introduce analysis of affected days caused by boundary updates - Refactor duplicated polygon parsing logic into `removeDuplicates` helper - Remove type change check from update analysis - Update `messages.properties` with recalculation hints and plural handling
- Drop `visits` and `preview_visits` tables - Delete `VisitJdbcService` and `PreviewVisitJdbcService` - Remove references and dependencies on visit-related services
- Add Maven usage rule to `CONVENTIONS.md` - Remove redundant `@DirtiesContext` annotation from `IntegrationTest` - Cleanup unused imports and redundant method calls in test classes - Adjust `createTestPlaceForUser` method with extended parameters for `SignificantPlace`
- Add method to mark location points as unprocessed for affected days - Update SQL queries with `ANY` syntax for improved array handling - Refactor `DataCleanupService` to trigger point recalculation after cleanup
- Adjust zoom-level thresholds and duration filters for visible visits - Simplify raw location loader path weight calculation - Update polygon logic for visit markers and place updates - Fix condition handling for overlapping and significant place changes
This was
linked to
issues
Dec 25, 2025
Closed
- Adjust expected visit timestamps to match updated processing logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.