Fix #885: Handle null names for un-geocoded significant places in memories#886
Merged
dgraf-gh merged 1 commit intodedicatedcode:mainfrom Apr 7, 2026
Merged
Fix #885: Handle null names for un-geocoded significant places in memories#886dgraf-gh merged 1 commit intodedicatedcode:mainfrom
dgraf-gh merged 1 commit intodedicatedcode:mainfrom
Conversation
dgraf-gh
requested changes
Apr 6, 2026
Contributor
dgraf-gh
left a comment
dgraf-gh
left a comment
There was a problem hiding this comment.
I added a remark, the rest looks good to me.
I am not sure if we let the code try to figure out what to display is the right move. The alternative would be to store null and display "unknown place".
At the moment, there is no way of renaming them later. I think we should keep the fallback for now and add a new feature where ot will be possible to rename a visit in the memory. Then we can drop the fallback again.
src/main/java/com/dedicatedcode/reitti/repository/MemoryVisitJdbcService.java
Outdated
Show resolved
Hide resolved
…edicatedcode#885 - Memory creation failed with NOT NULL constraint violation when significant places had not been geocoded and name was null.
dgraf-gh
approved these changes
Apr 6, 2026
Contributor
dgraf-gh
left a comment
dgraf-gh
left a comment
There was a problem hiding this comment.
Thank you for the effort. Looks good to me and will solve the immediate problem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Memory creation throws a SQL
NOT NULLconstraint violation onmemory_visits.namewhen a significant place has no geocoded name.Fix
V88__allow_null_name_in_memory_visits.sql: drops the NOT NULL constraint from memory_visits.nameMemoryVisit.java: create() now falls back to the place's city, or coordinates ("46.9728, 10.9687") if city is also absentMemoryVisitJdbcService.java: added a null guard before the INSERT as a second line of defenceFixes #885