Conversation
CertificateExtensions::read now ignores unrecognized extensions instead of returning UnknownCertificateExtension error. This fixes connections to servers that send signed_certificate_timestamp (18) or other valid CT extensions not currently parsed by rustls. Consistent with ClientExtensions, ServerExtensions, and NewSessionTicketExtensions which all ignore unknown extensions.
- Load native OS root CAs via rustls-native-certs alongside webpki roots - Add merged_root_store() to combine cached defaults with user-provided certs - Fix add_root_certificate() to pass certs through impersonation TLS config - Simplify build() match logic - Remove direct webpki-roots dependency from primp crate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1. Fix: ignore unknown TLS 1.3 certificate extensions
CertificateExtensions::readnow ignores unrecognized extensions instead ofreturning
UnknownCertificateExtensionerror. This fixes connections to serversthat send
signed_certificate_timestamp(18) or other valid CT extensions notcurrently parsed by rustls. Consistent with
ClientExtensions,ServerExtensions, andNewSessionTicketExtensionswhich all ignore unknownextensions. (RFC 8446 §4.4.2)
2. Add native OS root CAs and fix custom certs in impersonation path
rustls-native-certsalongside webpki roots,so connections trust system-installed certificates
merged_root_store()to combine cached default store with user-providedcustom certs
add_root_certificate()to pass certs through the impersonation TLSconfig (previously ignored when using TLS impersonation)
build()match logic from 6 arms to 2webpki-rootsdependency fromprimpcrate (now handledcentrally in
primp-reqwest)