Skip to content

fix(ux): update placeholder text on readOnly email field#81

Merged
deekshithgowda85 merged 1 commit into
deekshithgowda85:prodfrom
PranavAgarkar07:fix/34-placeholder-readonly-conflict-v2
Jun 2, 2026
Merged

fix(ux): update placeholder text on readOnly email field#81
deekshithgowda85 merged 1 commit into
deekshithgowda85:prodfrom
PranavAgarkar07:fix/34-placeholder-readonly-conflict-v2

Conversation

@PranavAgarkar07
Copy link
Copy Markdown
Contributor

@PranavAgarkar07 PranavAgarkar07 commented Jun 1, 2026

Changes the placeholder on the email field from "Enter your email" to "Email managed by provider" — the field is readOnly, so an instructional placeholder was misleading.

Closes #34

Summary by CodeRabbit

Release Notes

  • New Features
    • Enhanced account page with password visibility toggles for improved usability.
    • Added success notifications when saving profile and password updates.
    • Strengthened account deletion with confirmation requirement for security.
    • Display active sessions with individual revocation options.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 1, 2026

@PranavAgarkar07 is attempting to deploy a commit to the Deekshith Gowda HS's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 1, 2026

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The account settings page is refactored from a server-side authenticated component to a client-side React component. Auth and profile fetching logic are removed; the page now manages form interactions, password visibility, save feedback timers, and delete confirmation validation through local React state.

Changes

Account Page Client-Side Migration

Layer / File(s) Summary
Client-side imports and layout helpers
app/console/account/page.tsx (lines 1–25)
Replaces server-component and authentication imports with "use client" directive, React hooks (useState, useEffect, useRef), and lucide icons; introduces Section and Field layout helper components used throughout the page.
AccountPage client component with state-driven forms and confirmations
app/console/account/page.tsx (lines 27–201)
Rewrites AccountPage as a client-rendered component using local state for password visibility toggles (showCurrentPassword, showNewPassword), success feedback timers (saveSuccess, passwordSuccess), and delete-confirmation validation (deleteConfirmValue). Renders profile fields with defaultValue/readOnly attributes, an active sessions list with conditional "Current" badges and "Revoke" buttons, and a danger-zone delete confirmation flow. Removes all server-side user, session, and GitHub connection props.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • deekshithgowda85/SecDev#33: Modifies the same file to remove hardcoded profile values and replace them with defaultValue/placeholders; this PR completes the client-side migration by also removing server-side authentication and data fetching.

Suggested labels

gssoc:approved, level:intermediate, type:refactor, quality:clean

Poem

A server page transforms to client today,
No auth fetches—local state holds the way.
Password toggles dance, confirmations align,
Form feedback blooms, all state-driven fine. 🐇✨

🚥 Pre-merge checks | ✅ 1 | ❌ 4

❌ Failed checks (4 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes a specific, localized change (placeholder text on email field), but the PR summary shows massive scope: converting the entire AccountPage from server-rendered to client-side with extensive new UI logic beyond the placeholder fix. The PR title should reflect the comprehensive refactoring of AccountPage to a client component with new state management and UI features, not just the placeholder text change.
Linked Issues check ⚠️ Warning Issue #34 requires only updating the email field placeholder from 'Enter your email' to 'Email managed by provider', but the PR completely rewrites AccountPage from server to client component with extensive new functionality. Either revert the PR to include only the placeholder text fix as described in issue #34, or update the PR title and objectives to document the full refactoring scope.
Out of Scope Changes check ⚠️ Warning The PR introduces massive out-of-scope changes: converting from async server component to client component, adding password visibility toggles, success feedback, delete confirmation logic, and rewriting the entire AccountPage UI, far beyond the linked issue's placeholder text fix. Separate the placeholder text fix (issue #34) into its own minimal PR, and create a separate PR documenting the full AccountPage refactoring with its own linked issue.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@PranavAgarkar07
Copy link
Copy Markdown
Contributor Author

Replacing with properly formatted PR

@deekshithgowda85 deekshithgowda85 merged commit 2138764 into deekshithgowda85:prod Jun 2, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UX: Form field placeholder conflicts with readOnly attribute on account page

2 participants