references #106, on receiveding SIGUSR1, reopening log file to enable…#107
Merged
prashanthellina merged 2 commits intomasterfrom Jul 14, 2021
Merged
references #106, on receiveding SIGUSR1, reopening log file to enable…#107prashanthellina merged 2 commits intomasterfrom
prashanthellina merged 2 commits intomasterfrom
Conversation
… external log rotation tools to work
Member
Author
|
Please merge and release after your review. |
Member
Author
|
Force merged as merge will get blocked for you even after review approval due to broken CI config. Please review and post comments if any and proceed with release. |
Contributor
shivam05011996
left a comment
shivam05011996
left a comment
There was a problem hiding this comment.
Looks good to me.
Contributor
|
Will make a release. |
Contributor
|
Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… external log rotation tools to work
This fix ensures that when an external log rotation tool such as
logrotaterenames the current log file, it can inform the basescript based process by sending a SIGUSR1 signal. Upon receipt, basescript will now close the currently open log file and reopen it. This ensures that newly written log lines after the file move don't continue to go into the renamed file but instead to a file with the original file name.