Skip to content

#61 exposed init_logger and get_logger#63

Merged
2 commits merged into
masterfrom
unknown repository
Mar 28, 2018
Merged

#61 exposed init_logger and get_logger#63
2 commits merged into
masterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Mar 28, 2018

connected to #61

@ghost ghost added the Status: Needs review label Mar 28, 2018
@ghost ghost self-assigned this Mar 28, 2018
@ghost ghost requested a review from prashanthellina March 28, 2018 09:41
@ghost ghost added the inprogress-status label Mar 28, 2018
Comment thread README.md Outdated
read more about it at https://docs.python.org/2/library/logging.html.

### Metric-Grouping
We can collect the Metrics based on time interval.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rajendra-R Something like "When writing a log using self.log, you can specify type=metric. If this is done, a background thread will automatically group multiple such lines into one by averaging values (to prevent writing too many log lines)"

@ghost ghost merged commit c46d822 into deep-compute:master Mar 28, 2018
@ghost ghost deleted the expose_logger branch March 28, 2018 11:47
@ghost ghost mentioned this pull request Apr 4, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant