Setting outgoing protocol#89
Conversation
ghost
assigned
IdavalapatiRamanjaneyulu
requested review from
amaniyechuri,
jaswanth098,
prashanthellina and
venugopal-kandru
| self._invoke_pre_call_hook(request) | ||
| result = request.fn(**request.fn_params) | ||
|
|
||
| protocol = self._find_request_protocol(request) |
There was a problem hiding this comment.
@RamanjaneyuluIdavalapati What is this protocol used for??
There was a problem hiding this comment.
@jaswanth098 We use that protocol to serialise the response/result.
By default JSON protocol will be used to serialise and deserialise the incoming(client sends data to the server) and outgoing(server sends data to the client) data.
We can change this default protocol. Ref
But this protocol will be used to serialise and deserialise for both incoming and outgoing data.
I have supported here such that the user can change the protocol for outgoing data.
There was a problem hiding this comment.
got it thanks for clarification
| self._invoke_pre_call_hook(request) | ||
| result = request.fn(**request.fn_params) | ||
|
|
||
| protocol = self._find_request_protocol(request) |
There was a problem hiding this comment.
got it thanks for clarification
|
@RamanjaneyuluIdavalapati Please undo this merge. We should not be using request.headers as a mechanism to signal to kwikapi code that the response protocol is raw type. For this, we can use request.response.headers (which is not there today). Please add If the above is done, instead of In addition, we can take all the headers mentioned in request.response.headers and set them in the raw response so they are sent back to the caller. Please call me if this isn't clear. |
|
@prashanthellina How do I undo/revert the merge and commit here? I have seen this https://stackoverflow.com/questions/2389361/undo-a-git-merge-that-hasnt-been-pushed-yet. This will work in local. After doing the above should I commit again? |
|
@RamanjaneyuluIdavalapati No idea. Haven't done that before. |
|
@RamanjaneyuluIdavalapati you can see a revert option above beside the merge that amani has done |
|
@jaswanth098 I tried it, but it is creating another commit. |
|
Yes that is the revert commit that has to be applied in github, once a commit is made to the github it cannot be removed you can only make one more commit by removing all those changes that is what the above revert is about |
|
@jaswanth098 @prashanthellina If that is the case (commit can't be deleted), let me implement response headers and give pull request instead of reverting. It is because there is of no use with revert other than making duplicate commits. |
|
@jaswanth098 @prashanthellina This is working https://stackoverflow.com/questions/448919/how-can-i-remove-a-commit-on-github to remove the commit. But it will remove only visibility of the commit from the Github. If you have the commit id then you can still access the commit. |
|
@RamanjaneyuluIdavalapati That works. |
|
@prashanthellina will work on this tomorrow. Do I have write access to this repo? If I have I can simply remove the commit. Not sure will this work(removing) for pull request also? |
|
@RamanjaneyuluIdavalapati You have write access and that allows you to edit the code in the repo. |
|
@prashanthellina I don't have permission to push directly. May be this is because the branch is protected.
|
|
@RamanjaneyuluIdavalapati No one has permission to push to master you should start a pull request to master branch from a different branch |
|
@jaswanth098 Is this because of Github or we set up like this? If we set up like this can't we have permission for this push alone (Change the set up until this pull gets merge)? If we can't able to change it then I will give a pull request from different branch. Not sure whether we can able to merge or not. Not sure will this delete the commits. |
|
@RamanjaneyuluIdavalapati This is something that we did intentionally because no one pushes some buggy code to master with a review |
|
@jaswanth098 I have checked on my personal Github repository by pushing to different branch. When I tried to create a pull request it is saying no changes(even there are changes between commits) and not accepting the pull request.
You mean keep the commit as it is and proceed to implement further features? |
yes |
@jaswanth098 I have checked this on my personal Github repo. It worked there when I directly push to master. That is the reason I told this is working. |
@jaswanth098 @prashanthellina Example for the above. But anyway will not worry about this and will continue to implement further features as you suggested. |
4 participants
No description provided.